GrayFace wrote: Templayer wrote:
Sclerosis? Create Food.
Like that time when I was stuck in Sweet Water without food
Templayer wrote:Not to even mention the enemies that used Finger of Death now being pushovers, including the secret super-boos Q.
I haven't tried, but wonder why that is. There's still a death "Bonus" that Ancient Wyverns use, it should be attack bonus of Q and others. Though, it appears much more powerful than Finger of Death.
The reason why spells aren't changed is that it is pretty complicated. Places to change, new effects to add. NWC programmed them in the good old spaghetti code style
Yeah, I remember getting stuck somewhere in Jadame as well due to food shortage.
Yes, I do know that old spells would be a hassle to implement due to NWC's spaghetti code, but if there is ONE person on the entire planet that could do that, it is you.
Even though YOUR CODE ISN'T PERFECT EITHER.
Some constructive criticism:
1. sometimes I feel there is a lack of commentary. Do not be afraid to comment on even each line of code - it is not always needed, but sometimes it is better and in those cases don't be afraid to make one comment per one line of code.
2. After variable declaration, comment about what it is and what it is for, unless it is clear from it's name at a first glance by anybody.
3. Before function declaration, make a comment header, in which one line will be a description of what the function does, then one line per parameter saying what the parameter is and how it is used, and the last line being what the function returns (a description).
4. At work we are forbidden to use abbreviations. You would be sacked for your variable abbreviations at my job!
Example on the abbreviations:
If I were to give you only a bit of code, like this:
Code: Select all
local function set(p, v, a)
a = a or i4
if on then
last[p] = last[p] or a[p]
a[p] = math.max(v, last[p])
elseif last[p] then
a[p] = last[p]
No one would be able to tell what this function actually does, without looking it up and reading other stuff. If those variables weren't abbreviated (for example instead of "a" using visibilityLengthMatrix (or whatever that actually is)), the person reading it could immediately see that this specific block of code sets visibility. I made code like that once too. I was forbidden to, because it takes time for the next person editing it to find out what each variable means (and time costs money), while as if the variable name isn't called "a", "b" or "c", you usually do not have to deduce anything.
And I hope that piece of code was written by you, otherwise this is quite embarrassing. People that code solo tend to do these things, but then when you are cording in a team... this gets problematic.
But I am happy for all the hours you have spent reverse engineering the game. I couldn't do that.
Xfing wrote:Well I'm not sure how to feel about all those crazy innovations with character customization, since some of them seem to break the lore. There were never any spellcasting dragons in Enroth-based games, except for Faeries from Homm3, and zombie and skeletal characters by default would clash heavily with attributes such as intelligence or personality (zombification is supposed to minimize all your stats in addition to some other adverse effects). So as long as this is either lore-friendly or optional I guess we're good, but having a vanilla-friendly base version would also be nice to have. Stuff like a short Lich paperdoll for dwarf-based liches is definitely something overdue, but I'm not sure how you're going to go about making vampiric equivalents of regular non-vampire humanoids. Sounds like tons of work? : c
And here comes the purist.
THIS STUFF IS PURELY OPTIONAL. YOU WOULD HAVE TO SPECIFICALLY USE THE UNLOCKER TO SPECIFICALLY FOR EXAMPLE MAKE A DRAGON NECROMANCER.
If you do that, then you specifically want to have a dragon lich.
Also recheck your lore please. There is a spellcasting dragon in MM lore. Remember Heroes 3? Remember Mutare? She transformed into a dragon, and used ACTUAL MAGIC to force the Green and Golden dragons from AvLee to serve her!
And I believe by Enroth based you mean the world, not the continent. Otherwise we would only play as humans.
Zombification still reduces some of your stats, true. Did you try it? I thought it raised strength, actually. Rigor Mortis, you know? Too lazy to check, since you do not check your "facts" either. And the Vampire non-human variants would be available only by using my unlocker. -_-